fixed modernize-use-equals-delete warnings in headers#4177
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom Jun 7, 2022
Merged
fixed modernize-use-equals-delete warnings in headers#4177danmar merged 1 commit intocppcheck-opensource:mainfrom
modernize-use-equals-delete warnings in headers#4177danmar merged 1 commit intocppcheck-opensource:mainfrom
Conversation
Collaborator
As far as I know we have no check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not fixed in #4173 since the headers are still not included in the analysis (see #4100). They were also missed in #4175 since the checks wasn't enable then.
The fixed based on the check are using
= deleteand making the deleted memberspublicso they are actually being applied. I also corrected someoperator=signatures while at it.I am not sure if we have checks related to any of this so I have not filed any ticket (yet).